xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] PV-on-HVM: TSO support prior to 2.6.9 app

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] PV-on-HVM: TSO support prior to 2.6.9 appears to be unreliable,
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Fri, 10 Nov 2006 15:30:16 +0000
Delivery-date:	Fri, 10 Nov 2006 07:30:12 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
# Node ID 2df2acc057218e734381d8d300c43d7ba1a75d60
# Parent  60a4af3d243fb8c25dc7605287506125b0390a12
PV-on-HVM: TSO support prior to 2.6.9 appears to be unreliable,
especially when firewalling is enabled.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
---
 linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff -r 60a4af3d243f -r 2df2acc05721 
linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c
--- a/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Fri Nov 10 
12:34:26 2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Fri Nov 10 
12:34:28 2006 +0000
@@ -1623,8 +1623,16 @@ static void xennet_set_features(struct n
        if (!(dev->features & NETIF_F_IP_CSUM))
                return;
 
-       if (!xennet_set_sg(dev, 1))
-               xennet_set_tso(dev, 1);
+       if (xennet_set_sg(dev, 1))
+               return;
+
+       /* Before 2.6.9 TSO seems to be unreliable so do not enable it
+        * on older kernels.
+        */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,9)
+       xennet_set_tso(dev, 1);
+#endif
+
 }
 
 static int network_connect(struct net_device *dev)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] PV-on-HVM: TSO support prior to 2.6.9 appears to be unreliable,, Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] [LIBFSIMAGE] Don't leak FDs or RAM when closing filesystems, Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] PV-on-HVM: Do not enable barriers in blkfront before 2.6.16, Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] [LIBFSIMAGE] Don't leak FDs or RAM when closing filesystems, Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] PV-on-HVM: Do not enable barriers in blkfront before 2.6.16, Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]