[Xen-changelog] Fix e820 array stack overflow

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User iap10@xxxxxxxxxxxxxxxxxxxxx
# Node ID 80b0fbf1c4a12d97e89744330eca11ffa2442342
# Parent  fbdbe4fc218de40d5176e0104908e05fb6e2c6ce
Fix e820 array stack overflow
I don't see the problem on machine that I typically use, but I found and
fixed the problem on a big machine. It was causing a stack overflow. If
you look at the current code, it's a bit dangerous, see => part. This
patch fixes it.
From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Signed-off-by: ian@xxxxxxxxxxxxx

diff -r fbdbe4fc218d -r 80b0fbf1c4a1 xen/arch/x86/setup.c
--- a/xen/arch/x86/setup.c      Wed Aug 17 18:22:18 2005
+++ b/xen/arch/x86/setup.c      Wed Aug 17 22:01:24 2005
@@ -244,6 +244,8 @@
 
 #define EARLY_FAIL() for ( ; ; ) __asm__ __volatile__ ( "hlt" )
 
+static struct e820entry e820_raw[E820MAX];
+
 void __init __start_xen(multiboot_info_t *mbi)
 {
     char *cmdline;
@@ -253,7 +255,6 @@
     unsigned long _initrd_start = 0, _initrd_len = 0;
     unsigned int initrdidx = 1;
     physaddr_t s, e;
-    struct e820entry e820_raw[E820MAX];
     int i, e820_raw_nr = 0, bytes = 0;
     struct ns16550_defaults ns16550 = {
         .data_bits = 8,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog