[Xen-changelog] [PATCH] Use copy_from_user when accessing guest_pt[]

[BitKeeper Bot <riel@xxxxxxxxxxx>]

ChangeSet 1.1782, 2005/06/30 09:10:15+01:00, arun.sharma@xxxxxxxxx

        [PATCH] Use copy_from_user when accessing guest_pt[]
        
        Use copy_from_user when accessing guest_pt[]
        
        Signed-off-by: Arun Sharma <arun.sharma@xxxxxxxxx>



 shadow.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)


diff -Nru a/xen/arch/x86/shadow.c b/xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c     2005-06-30 05:04:10 -04:00
+++ b/xen/arch/x86/shadow.c     2005-06-30 05:04:10 -04:00
@@ -1906,7 +1906,7 @@
     unsigned long gpfn, unsigned index)
 {
     unsigned long smfn = __shadow_status(d, gpfn, PGT_snapshot);
-    l1_pgentry_t *snapshot; // could be L1s or L2s or ...
+    l1_pgentry_t *snapshot, gpte; // could be L1s or L2s or ...
     int entries_match;
 
     perfc_incrc(snapshot_entry_matches_calls);
@@ -1916,10 +1916,14 @@
 
     snapshot = map_domain_page(smfn);
 
+    if (__copy_from_user(&gpte, &guest_pt[index],
+                         sizeof(gpte)))
+        return 0;
+
     // This could probably be smarter, but this is sufficent for
     // our current needs.
     //
-    entries_match = !l1e_has_changed(guest_pt[index], snapshot[index],
+    entries_match = !l1e_has_changed(gpte, snapshot[index],
                                      PAGE_FLAG_MASK);
 
     unmap_domain_page(snapshot);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog