xen-changelog

[Top] [All Lists]

[Xen-changelog] Fix the x86/64 build. My change to make PAGE_SIZE a sign

from [BitKeeper Bot]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Fix the x86/64 build. My change to make PAGE_SIZE a signed quantity
From:	BitKeeper Bot <riel@xxxxxxxxxxx>
Date:	Thu, 23 Jun 2005 09:41:14 +0000
Cc:	james@xxxxxxxxxxxxx
Delivery-date:	Thu, 23 Jun 2005 11:04:39 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

ChangeSet 1.1734, 2005/06/23 10:41:14+01:00, kaf24@xxxxxxxxxxxxxxxxxxxx

        Fix the x86/64 build. My change to make PAGE_SIZE a signed quantity
        also made it int rather than long, which turns out to break stuff.
        Debugged by Xin Li at Intel.
        Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>



 page.h |    4 ++++
 1 files changed, 4 insertions(+)


diff -Nru a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h
--- a/xen/include/asm-x86/page.h        2005-06-23 07:05:51 -04:00
+++ b/xen/include/asm-x86/page.h        2005-06-23 07:05:51 -04:00
@@ -6,7 +6,11 @@
  * It is important that the masks are signed quantities. This ensures that
  * the compiler sign-extends a 32-bit mask to 64 bits if that is required.
  */
+#ifndef __ASSEMBLY__
+#define PAGE_SIZE           (1L << PAGE_SHIFT)
+#else
 #define PAGE_SIZE           (1 << PAGE_SHIFT)
+#endif
 #define PAGE_MASK           (~(PAGE_SIZE-1))
 #define PAGE_FLAG_MASK      (~0)
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Fix the x86/64 build. My change to make PAGE_SIZE a signed quantity, BitKeeper Bot <=

Previous by Date:	[Xen-changelog] The 32-bit x86 LTP exposed bugs with LDT handling with x86_64 Xen and, BitKeeper Bot
Next by Date:	[Xen-changelog] Don't zero the vcpu flags in domain builder., BitKeeper Bot
Previous by Thread:	[Xen-changelog] The 32-bit x86 LTP exposed bugs with LDT handling with x86_64 Xen and, BitKeeper Bot
Next by Thread:	[Xen-changelog] Don't zero the vcpu flags in domain builder., BitKeeper Bot
Indexes:	[Date] [Thread] [Top] [All Lists]