xen-changelog

[Top] [All Lists]

[Xen-changelog] skb_copy_bits() can return an err, so have netif_be_star

from [BitKeeper Bot]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] skb_copy_bits() can return an err, so have netif_be_start_xmit()
From:	BitKeeper Bot <riel@xxxxxxxxxxx>
Date:	Thu, 02 Jun 2005 08:10:58 +0000
Delivery-date:	Thu, 02 Jun 2005 09:02:17 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

ChangeSet 1.1632, 2005/06/02 09:10:58+01:00, kaf24@xxxxxxxxxxxxxxxxxxxx

        skb_copy_bits() can return an err, so have netif_be_start_xmit()
        crash informatively.
        Signed-off-by: Nivedita Singhvi <niv@xxxxxxxxxx>



 netback.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)


diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c 
b/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c
--- a/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c     2005-06-02 
05:03:09 -04:00
+++ b/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c     2005-06-02 
05:03:09 -04:00
@@ -153,7 +153,8 @@
             goto drop;
         skb_reserve(nskb, hlen);
         __skb_put(nskb, skb->len);
-        (void)skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen);
+        if (skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen))
+            BUG();
         nskb->dev = skb->dev;
         nskb->proto_csum_valid = skb->proto_csum_valid;
         dev_kfree_skb(skb);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] skb_copy_bits() can return an err, so have netif_be_start_xmit(), BitKeeper Bot <=

Previous by Date:	[Xen-changelog] Merge firebug.cl.cam.ac.uk:/auto/groups/xeno-xenod/BK/xen-unstable.bk, BitKeeper Bot
Next by Date:	[Xen-changelog] [PATCH] vmx-mmio-2pages.patch, BitKeeper Bot
Previous by Thread:	[Xen-changelog] All page directory pages have to be pinned before/during relocation, so, BitKeeper Bot
Next by Thread:	[Xen-changelog] [PATCH] vmx-mmio-2pages.patch, BitKeeper Bot
Indexes:	[Date] [Thread] [Top] [All Lists]