[Xen-bugs] [Bug 1686] New: regression: libxenstore leaks pipes

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1686

           Summary: regression: libxenstore leaks pipes
           Product: Xen
           Version: unstable
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: jl@xxxxxx


Since cca xen-4.0.1rc5 (detailed commit info bellow) xenstore leaks 2 pipes and
one socket on each connection. It does not hurt if application is short-lived,
but it hurts libvirt daemon, which is supposed to run for prolonged period.

Steps to reproduce:
1. install xen-4.0.1rc5 or newer machine
2. install libvirt (tested with 0.7.6 and 0.8.1 to 0.8.4)
3. for i in `seq 1 1000`; do virsh -c xen:/// list; done
4. see lsof | grep libvirt

it will eventually die with too many files open (cca on i=330).

I have done git bisect and fond a commit which caused this regression:

8b490610757b1c81131c1876a54fd0bfec301c52 is first bad commit
commit 8b490610757b1c81131c1876a54fd0bfec301c52
Author: Keir Fraser <keir.fraser@xxxxxxxxxx>
Date:   Tue Jul 6 16:49:01 2010 +0100

    libxl: Backported stuff from unstable

    Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>


Trivial patch solves this problem:
--- tools/xenstore/xs.c.orig    2010-11-10 13:18:05.000000000 +0000
+++ tools/xenstore/xs.c 2010-11-10 13:18:31.000000000 +0000
@@ -285,6 +285,7 @@
        mutex_unlock(&h->request_mutex);
        mutex_unlock(&h->reply_mutex);
        mutex_unlock(&h->watch_mutex);
+       close_fds_free(h);
 }

 static bool read_all(int fd, void *data, unsigned int len)





More info on this issue can be found in xen-users list in this thread:
http://lists.xensource.com/archives/html/xen-users/2010-11/msg00201.html


-- 
Configure bugmail: 
http://bugzilla.xensource.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

_______________________________________________
Xen-bugs mailing list
Xen-bugs@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-bugs