[Xen-bugs] [Bug 1490] New: vif-common.sh frob_iptable() always logs iptables setup failed

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1490

           Summary: vif-common.sh frob_iptable() always logs iptables setup
                    failed
           Product: Xen
           Version: unstable
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: john.haxby@xxxxxxxxxx


During network setup, the frob_iptable() shell function is called and this
includes a check to make sure that the iptables commands invoked worked.

Unfortunately the test is always true:

   if [ "$command" == "online" ] && [ $? ]

The second test here is the one that fails: that form of the test is false if
$? is the empty string and true otherwise: as $? is a numeric exit status it is
always non-empty and so we always get the error logged.


-- 
Configure bugmail: 
http://bugzilla.xensource.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

_______________________________________________
Xen-bugs mailing list
Xen-bugs@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-bugs