WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

[Xen-API] [PATCH 7 of 8] [CA-31705] Improves error handling within vm-me

To: xen-api@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-API] [PATCH 7 of 8] [CA-31705] Improves error handling within vm-memory-target-wait
From: Jonathan Knowles <jonathan.knowles@xxxxxxxxxxxxx>
Date: Mon, 1 Feb 2010 09:19:09 +0000
Delivery-date: Mon, 01 Feb 2010 01:35:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1265015942@radon>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Jonathan Knowles <jonathan.knowles@xxxxxxxxxxxxx>
# Date 1264783041 0
# Node ID 8f7fbffae087f6a9292de089226977bf9291c7d5
# Parent  2ae5e49447b6c40b76b02c8e170b20b81d3c8263
[CA-31705] Improves error handling within vm-memory-target-wait.

Upgrades the timeout error handler so that it reports the last-seen values of 
memory_actual and memory_target, rather than an opaque task reference.

Signed-off-by: Jonathan Knowles <jonathan.knowles@xxxxxxxxxxxxx>

diff -r 2ae5e49447b6 -r 8f7fbffae087 ocaml/xapi/xapi_vm_helpers.ml
--- a/ocaml/xapi/xapi_vm_helpers.ml     Fri Jan 29 16:37:15 2010 +0000
+++ b/ocaml/xapi/xapi_vm_helpers.ml     Fri Jan 29 16:37:21 2010 +0000
@@ -695,7 +695,9 @@
                        if accumulated_wait_time_seconds > timeout_seconds
                                then raise (Api_errors.Server_error
                                        
(Api_errors.vm_memory_target_wait_timeout,
-                                       [Ref.string_of (Context.get_task_id 
__context)]));
+                                       [ Printf.sprintf "target = %Ld bytes" 
memory_target_bytes
+                                       ; Printf.sprintf "actual = %Ld bytes" 
memory_actual_bytes
+                                       ]));
                        (* The memory target has not yet been reached: *)
                        (* wait for a while before repeating the test. *)
                        Thread.delay 1.0;
1 file changed, 3 insertions(+), 1 deletion(-)
ocaml/xapi/xapi_vm_helpers.ml |    4 +++-


Attachment: xen-api.hg-8.patch
Description: Text Data

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api